Closed
Conversation
Owner
|
Thanks for proactively bringing this over. One of the commits in PR might obsolete it, I've been trying to come up with a way to more safely ensure certain vars are set like this, the consensus with Jason seemed to be using openshift_common for that, so I moved repoquery_cmd into that as the first example: https://github.com/dgoodwin/openshift-ansible/blob/upgrade33/roles/openshift_common/tasks/main.yml#L49 Hopefully this will prevent similar problems going forward, will close this but let me know if you forsee any issues. |
dgoodwin
pushed a commit
that referenced
this pull request
Oct 5, 2016
Filterize haproxy front/backends and add method for specifying custom front/backends
dgoodwin
pushed a commit
that referenced
this pull request
Oct 11, 2016
Restore mistakenly reverted code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only problem i found when i went through a 3.1 to 3.2 upgrade. I don't recall if this PR was meant to include 3.1 to 3.2 or not.